Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Free all the icons #313

Merged

Conversation

geekingfrog
Copy link
Contributor

Fix #242

This is mostly a mindless search&replace and checking that everything looks good with a root account locally.
No attempt to refactor the icon and styling system, so there's still a little bit of duplication.

Some icons had to be swapped for a free version.

No duotone icon is free, so replace all of them with the solid variant
that *is* free.
Also replace a few icons for a free alternative
@geekingfrog geekingfrog marked this pull request as ready for review June 7, 2024 19:01
@StanczakDominik
Copy link
Collaborator

This is one of those cases where I'm just going to merge this and gather feedback on any missing or broken icons later, as it's not at all critical for operation :)

@StanczakDominik StanczakDominik merged commit 902fbad into beyond-all-reason:master Jun 9, 2024
1 check failed
@geekingfrog geekingfrog deleted the free-all-the-icons branch June 9, 2024 17:47
geekingfrog added a commit to geekingfrog/teiserver that referenced this pull request Jun 11, 2024
StanczakDominik added a commit that referenced this pull request Jun 12, 2024
* Wrap the content into a container

* Swap the icons for free ones

A few that were missed during
#313

* Apply mix format

---------

Co-authored-by: Dominik Stańczak-Marikin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop depending on non-free fontawesome
2 participants